[feat] S3ArtifactStorage custom boto3 client parameters #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
alberttorosyan
changed the title
There was a problem hiding this comment.
@sbatchelder the changes look good! Could you please sign CLA so we can proceed with the merge?
|
@alberttorosyan Since the contribution is related to my workplace, I may or may not have Signatory Authority. I'm waiting on my org's legal team to review and get back to me regarding the CLA... |
|
@alberttorosyan I signed the CLA! and added documentation since you last reviewed this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to feature request #3257
as discussed on the Aim discord Contributing channel Nov 21st, and with blessings from gev and albert.1990
This is one of my first PRs to a 3rd party OpenSource project. If I missed something wrt the Contributing Guidelines or something else please lmk.