-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Integrate Ruff for lint & format #3125
Conversation
@alberttorosyan @mihran113 would appreciate review comments on this PR. This PR changes only import orders, double quotes, simple limiting rules. |
@mihran113 Can I get review of the PR? Please let me know if I need to change anything. Thanks |
Hi All, |
Hi @Sharathmk99! Sorry for late response; we are still in the process of deciding on the linting and formatting, but will most probably end up using combination of |
Thank you for your response. |
@SGevorg @alberttorosyan As agreed I have reopened the PR and configured to use single quotes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sharathmk99, sorry for late response; took some time to go through the changes.
Everything looks good, seems there are some minor fixes left (the workflow fails on the code style checks due to some import redefinitions). Once done, we can proceed with merge
@alberttorosyan Thank you for the review. I have made the changes and tested locally. Could you please approve CI workflow so I can test in Github actions as well? Thank you!! |
Hey @Sharathmk99! Seems workflow passes the steps required(performance tests are not up to date, so that fail is expected). @alberttorosyan is away for the upcoming week, so if there're no more changes pending from your end, I'll proceed to merge the PR. |
Hm, after I've fixed the merge conflict, the new check shows that one more file needs reformatting (not the conflicting file). @Sharathmk99 could you please update that as well? |
On it now. Thanks |
Done. Please do approve Github actions workflow, we should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for contribution @Sharathmk99! Everything looks good now, proceeding to merge! 🎉
Thank you @mihran113. |
Ruff integration for lint & format to maintain code standardisation.
Fixes - #3124 #3099
It works perfectly fine with vscode extension