DevOps: only run Slack notification if tests failed #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow was recently adapted to correct the action being marked as successful even when the tests failed. This was done by removing the `continue-on-error` option, which ignores the error. To still have the Slack option run on error, the `if: always()` condition was added. This works in the case of an error, but it also made that the step would always run, even when the tests pass just fine. The solution is to keep the explicit check on the exit status of the install and tests steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow was recently adapted to correct the action being marked as
successful even when the tests failed. This was done by removing the
continue-on-erroroption, which ignores the error. To still have theSlack option run on error, the
if: always()condition was added. Thisworks in the case of an error, but it also made that the step would
always run, even when the tests pass just fine. The solution is to keep
the explicit check on the exit status of the install and tests steps.