Parsers: add exception title to ERROR_UNEXPECTED_PARSER_EXCEPTION
#793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact exception and its stack trace was already added as a log to the relevant process node, however, most often only the exit message is shown. Currently this would only show the base message that an unexpected exception occurred which is not very informative and one would have to run other commands to find out more. By adding the exception title in the exit message itself, one has more information directly.
I asked him to open it, so I think it is fine to merge. |
mbercx
pushed a commit
to mbercx/aiida-quantumespresso
that referenced
this pull request
Mar 17, 2022
…iidateam#793) The exact exception and its stack trace was already added as a log to the relevant process node, however, most often only the exit message is shown. Currently this would only show the base message that an unexpected exception occurred which is not very informative and one would have to run other commands to find out more. By adding the exception title in the exit message itself, one has more information directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #791
The exact exception and its stack trace was already added as a log to
the relevant process node, however, most often only the exit message is
shown. Currently this would only show the base message that an
unexpected exception occurred which is not very informative and one
would have to run other commands to find out more. By adding the
exception title in the exit message itself, one has more information
directly.