Pre-commit: move pytest and pylint config to pyproject.toml
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
reviewed
Sep 29, 2020
sphuber
force-pushed
the
fix/561/pyproject-configuration
branch
from
99e78b9
to
921c2ad
Compare
sphuber
force-pushed
the
fix/561/pyproject-configuration
branch
2 times, most recently
from
f8d3553
to
d745e2d
Compare
Requirement of `pylint` is upped as support for `pyproject.toml` was only added in v2.6.0. Also remove all explicit marking of tests with the `aiida_profile` fixture. This is automatically loaded for the entire session by calling `pytest_plugins = ['aiida.manage.tests.pytest_fixtures']` in the `conftext.py`. Finally, move `yapf` pre-commit hook before the `pylint` one. Often `yapf` will correct mistakes that `pylint` will otherwise complain about.
sphuber
force-pushed
the
fix/561/pyproject-configuration
branch
from
d745e2d
to
9d6ea64
Compare
|
@greschd should be good now |
greschd
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #561
Requirement of
pylintis upped as support forpyproject.tomlwasonly added in v6.0.