-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to run a NamelistCalculation using symlinks to the parent_folder #555
Merged
sphuber
merged 19 commits into
aiidateam:develop
from
Crivella:feature-NamelistCalc_with_symlinks
Sep 22, 2020
Merged
Possibility to run a NamelistCalculation using symlinks to the parent_folder #555
sphuber
merged 19 commits into
aiidateam:develop
from
Crivella:feature-NamelistCalc_with_symlinks
Sep 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary from the 'prepare_for_submission' method of a 'NamelistsCalculation' CalcJob.
sphuber
requested changes
Sep 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Crivella , this looks fine. Could you just please add a quick test?
Crivella
force-pushed
the
feature-NamelistCalc_with_symlinks
branch
from
September 19, 2020 23:31
d9eea2d
to
517d4bf
Compare
@sphuber |
sphuber
approved these changes
Sep 22, 2020
Thanks a lot @Crivella |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most use-cases, the calculations that are a subclass of
NamelistCalculation
, are used for post-processing that only reads data from the ./out/ folder of a scf/nscf calculation.I find it useful to have the option of symlinking the ./out/ folder instead of straight out copying it as it avoids, in some cases, to have to copy 10s to 100s of GB of data, slowing down the starting of the job, and having to clear the remote_data afterwards to avoid huge disk consumption on the cluster.
With this pull request, the option to symlink the ./out/ folder is by default off (to be consistent with older inputs) and is turned on by specifying
'PARENT_FOLDER_SYMLINK': True
in thesettings
input Dict node.