-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2 support #515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aw yeah 🥳 I've added a few minor comments - good to go for me once the tests pass.
@@ -86,14 +83,13 @@ | |||
}, | |||
"install_requires": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we were missing the six
requirement before 😅
It seems the |
79a730c
to
d543396
Compare
yeah, in my other projects I therefore split the |
Yeah I think that's good practice anyway - the fewer extra dependencies are installed when testing, the less likely to forget something that should be in |
The following commands were executed to clean all source files: sed -i '/from __future__.*$/d' {} + sed -i 's/(object):/:/g' {} + sed -i 's/super([^)]*,[^)]*)/super()/g' {} + sed -i '/\(import six\|from six\).*$/d' {} + sed -i '/\(six\.add_metaclass\).*$/d' {} + sed -i 's/six.integer_types/int/g' {} + sed -i 's/six.string_types/str/g' {} + sed -i 's/six.text_type/str/g' {} + sed -i 's/six.binary_type/bytes/g' {} + sed -i 's/six.moves.StringIO/io.StringIO/g' {} + sed -i 's/six.StringIO/io.StringIO/g' {} + sed -i 's/six.moves.BytesIO/io.BytesIO/g' {} + sed -i 's/six.BytesIO/io.BytesIO/g' {} + sed -i 's/six.moves.range/range/g' {} + sed -i 's|six.iterkeys(\([^)]*\))|\1.keys()|' {} + sed -i 's|six.iteritems(\([^)]*\))|\1.items()|' {} + sed -i 's|six.itervalues(\([^)]*\))|\1.values()|' {} + The operations were applied to all files using `find -exec`: find . -type f -not -path './.git*' -exec Note the exclusion of the `.git` folder which is very important.
d543396
to
c3348b3
Compare
Fixes #514
The following commands were executed to clean all source files:
The operations were applied to all files using
find -exec
:Note the exclusion of the
.git
folder which is very important.