Fix the requirements string for aiida-core and atomic_tools optional #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional needs to directly follow the dependency name. I also removed the `atomic_tools` option in `.travis.yml` when installing the aiida-quantumespresso package, as it does not have this optional requirement group
giovannipizzi
approved these changes
Jun 13, 2018
|
Thanks! P.S. I would like to start using rebase merge's to avoid the merge commits, specially for these single commit PR's it significantly reduces the number of noisy unnecessary commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
The optional needs to directly follow the dependency name. I also
removed the
atomic_toolsoption in.travis.ymlwhen installingthe
aiida-quantumespressopackage, as it does not have this optionalrequirement group