Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "install_requires" from aiida to aiida-core #20

Closed
chrisjsewell opened this issue Aug 27, 2018 · 2 comments · Fixed by aiidateam/aiida-diff#5 or #22
Closed

Update "install_requires" from aiida to aiida-core #20

chrisjsewell opened this issue Aug 27, 2018 · 2 comments · Fixed by aiidateam/aiida-diff#5 or #22

Comments

@chrisjsewell
Copy link
Member

One of the major reasons to do this is that readthedocs builds seem to fail with aiida (https://readthedocs.org/projects/aiida-crystal17/builds/7693840/) but not with aiida-core

I'd also note that, for some reason I get an ImportError for pgtest during tests, unless I specifically but it in the requirements (even though it seems to be in the aiida-core[testing] requirements?)

{
    "install_requires": [
        "aiida-core>=0.12.0,<1.0.0"
    ],
    "extras_require": {
        "testing": [
            "aiida-core[testing]",
            "wheel>=0.31",
            "pgtest"
        ]
   }
}
@ltalirz
Copy link
Member

ltalirz commented Aug 27, 2018

Thanks a lot for these suggestions, will look into this!

ltalirz added a commit to ltalirz/aiida-diff that referenced this issue Aug 27, 2018
fix aiidateam/aiida-plugin-cutter#20

 * limit aiida version to <1.0
 * switch from aiida to aiida-core
 * use aiida's prerequisites for pre-commit
@ltalirz
Copy link
Member

ltalirz commented Aug 28, 2018

I can reproduce the pgtest import error

The travis log shows that pgtest is not installed (nor are any other "testing" dependencies of aiida-core).
This is not the fault of the aiida-core wheel used, whose METADATA contains the line

Requires-Dist: pgtest (==1.1.0); extra == 'testing'

It turns out that putting the same dependency with different extras is an unresolved pip issue.
It means we will need to replicate the dependencies needed for testing.

ltalirz added a commit to aiidateam/aiida-diff that referenced this issue Aug 28, 2018
address aiidateam/aiida-plugin-cutter#20

 * limit aiida version to <1.0
 * switch from aiida to aiida-core
* add dependencies explicitly, working around pypi bug pypa/pip#4957
ltalirz added a commit to ltalirz/aiida-plugin-cutter that referenced this issue Aug 28, 2018
fix aiidateam#20

 * limit aiida version to <1.0
 * switch from aiida to aiida-core
 * add dependencies explicitly, working around pypi bug pypa/pip#4957
 * switch to aiida 0.12 as default minimum version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants