ORM: Fix ProcessNode.get_builder_restart
#6284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/5977/get-builder-restart-metadata
branch
from
a98fe31
to
1640f99
Compare
|
@mbercx this should fix the issue you opened. Got a reproducible case from someone else and they confirm that this fix solves the problem. |
|
@mbercx want to have a look at this? Otherwise I am going to merge this |
The `get_builder_restart` would fail if the process input specification contained the inputs of a `CalcJob`. The method would first assign the regular inputs to the builder followed by the metadata. However, each time the builder is updated, the validation is triggered. The normal inputs do not contain the required metadata, such as the `resources` option, causing the validation to fail. The solution is to update the builder with the complete set of inputs in one go, merging the normal inputs with the metadata inputs prior to that.
sphuber
force-pushed
the
fix/5977/get-builder-restart-metadata
branch
from
1640f99
to
9bdcc09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5977
The
get_builder_restartwould fail if the process input specification contained the inputs of aCalcJob. The method would first assign the regular inputs to the builder followed by the metadata. However, each time the builder is updated, the validation is triggered. The normal inputs do not contain the required metadata, such as theresourcesoption, causing the validation to fail.The solution is to update the builder with the complete set of inputs in one go, merging the normal inputs with the metadata inputs prior to that.