Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Update pre-commit requirement isort==5.12.0 #5877

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jan 30, 2023

Older versions were breaking due to a release of poetry-core causing our pre-commit job in the CI to fail. For details, see: PyCQA/isort#2077

Older versions were breaking due to a release of `poetry-core` causing
our pre-commit job in the CI to fail. For details, see:
PyCQA/isort#2077
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 79.65% // Head: 79.69% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (2c0e53d) compared to base (9aca3e1).
Patch coverage: 93.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5877      +/-   ##
==========================================
+ Coverage   79.65%   79.69%   +0.05%     
==========================================
  Files         545      546       +1     
  Lines       39167    39344     +177     
==========================================
+ Hits        31194    31353     +159     
- Misses       7973     7991      +18     
Impacted Files Coverage Δ
aiida/cmdline/commands/cmd_setup.py 95.20% <ø> (ø)
aiida/orm/computers.py 82.75% <0.00%> (ø)
aiida/orm/nodes/process/calculation/calcjob.py 73.79% <ø> (-3.35%) ⬇️
aiida/tools/query/calculation.py 91.79% <ø> (ø)
aiida/cmdline/commands/cmd_calcjob.py 77.42% <67.57%> (-2.44%) ⬇️
aiida/manage/external/postgres.py 82.15% <75.00%> (ø)
aiida/orm/utils/serialize.py 91.16% <92.00%> (-0.71%) ⬇️
aiida/tools/visualization/graph.py 82.36% <93.94%> (-0.75%) ⬇️
aiida/cmdline/commands/cmd_computer.py 81.82% <96.43%> (+0.87%) ⬆️
aiida/__init__.py 75.00% <100.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sphuber sphuber merged commit dc41653 into main Jan 30, 2023
@sphuber sphuber deleted the fix/isort branch January 30, 2023 09:05
sphuber added a commit that referenced this pull request Feb 8, 2023
Older versions were breaking due to a release of `poetry-core` causing
our pre-commit job in the CI to fail. For details, see:
PyCQA/isort#2077

Cherry-pick: dc41653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant