-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: Update requirements for kiwipy
and plumpy
#5732
Conversation
2088647
to
d8e5693
Compare
d8e5693
to
31a152d
Compare
31a152d
to
ef092bd
Compare
82d38fc
to
1f22365
Compare
There is a single bug that prevents this from being merged. Once the |
1f22365
to
578044e
Compare
7af5355
to
6a31919
Compare
6a31919
to
a4ead79
Compare
800a73c
to
fb1d2f6
Compare
fb1d2f6
to
4ba3e6a
Compare
f55080f
to
8229a7c
Compare
f0d0b48
to
e428cf3
Compare
12d1fd3
to
adfac17
Compare
c4186ee
to
564f908
Compare
564f908
to
da24249
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5732 +/- ##
==========================================
+ Coverage 77.51% 77.79% +0.29%
==========================================
Files 560 561 +1
Lines 41444 41819 +375
==========================================
+ Hits 32120 32530 +410
+ Misses 9324 9289 -35 ☔ View full report in Codecov by Sentry. |
da24249
to
aead553
Compare
The new version `kiwipy==0.8` and `plumpy==0.22` provide compatiblity with newer versions of `aio-pika==8.0` which comes with various connection stability improvements. The only known problem is that `Communicator.close()` times out if at least one process has been run. A test is added to capture this behavior in `tests/manage/test_manager.py` which currently fails as a `TimeoutError` is thrown. A lot of debugging has not yet led to finding the cause nor a solution. Since this behavior only seems to be appearing in the tests and does not seem to affect regular usage, the upgrade is accepted regardless.
The exception is caught and logged as a warning.
aead553
to
323acee
Compare
Fixes #4595
The new version
kiwipy==0.8
andplumpy==0.22
provide compatiblity with newer versions ofaio-pika==9.0
which comes with various connection stability improvements.