🐛 FIX: Archive creation after packing repository #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`disk_objectstore.PackedObjectReader` does not implement the ability `SEEK_END`, required to determine the size of a stream. The size of the stream is required to determine if the ZIP64 extension should be used, so n this case, we now defer to `force_zip64=True`.
sphuber
pushed a commit
that referenced
this pull request
Sep 22, 2022
`disk_objectstore.PackedObjectReader` does not implement the ability to `SEEK_END`, required to determine the size of a stream. The size of the stream is required to determine if the ZIP64 extension should be used, so in this case, we now defer to `force_zip64=True`. Cherry-pick: 46d244e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5564
disk_objectstore.PackedObjectReaderdoes not implement the ability toSEEK_END,required to determine the size of a stream.
The size of the stream is required to determine if the ZIP64 extension should be used,
so in this case, we now defer to
force_zip64=True.