Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy tests/utils/configuration.py #5500

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Apr 27, 2022

Fixes #4249

These utilities have been replaced with pytest fixtures defined in
conftest.py, most notable, empty_config and profile_factory. The
tests that were using the legacy utils have been refactored.

These utilities have been replaced with `pytest` fixtures defined in
`conftest.py`, most notable, `empty_config` and `profile_factory`. The
tests that were using the legacy utils have been refactored.
@sphuber sphuber force-pushed the fix/4249/remove-tests-utils-configuration branch from 7e5e6ca to e4e4a1c Compare May 12, 2022 12:16
@sphuber
Copy link
Contributor Author

sphuber commented May 12, 2022

@ramirezfranciscof @chrisjsewell let me know if you want to review this, otherwise I am merging it tomorrow

@sphuber sphuber merged commit 137bf8e into aiidateam:main May 13, 2022
@sphuber sphuber deleted the fix/4249/remove-tests-utils-configuration branch May 13, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace tests.utils.configuration with the corresponding pytest fixtures
1 participant