-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 MAINTAIN: Move pylint plugin to external package #5190
🔧 MAINTAIN: Move pylint plugin to external package #5190
Conversation
This will allow pylint/pre-commit to be called from anywhere, and also allows for plugins to use it if necessary.
I guess this seems a good a place as any to house it @sphuber? As mentioned in #5182, there is probably some improvements that can be made with this plugin, but I think it's already better than having to add a tonne of pylint disables, for uses of e.g. |
The other approach would be to turn it into a standalone package. I can do that but probably not today |
Codecov Report
@@ Coverage Diff @@
## develop #5190 +/- ##
========================================
Coverage 81.00% 81.00%
========================================
Files 535 535
Lines 37402 37402
========================================
Hits 30293 30293
Misses 7109 7109
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
That's what I was going to suggest. No need to do it today |
Ok moved it to https://github.com/aiidateam/pylint-aiida |
This will allow pylint/pre-commit to be called from anywhere,
and also allows for plugins to use it if necessary.