Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Move pylint plugin to external package #5190

Merged
merged 8 commits into from
Oct 26, 2021

Conversation

chrisjsewell
Copy link
Member

This will allow pylint/pre-commit to be called from anywhere,
and also allows for plugins to use it if necessary.

This will allow pylint/pre-commit to be called from anywhere,
and also allows for plugins to use it if necessary.
@chrisjsewell chrisjsewell requested a review from sphuber October 20, 2021 09:21
@chrisjsewell
Copy link
Member Author

I guess this seems a good a place as any to house it @sphuber?

As mentioned in #5182, there is probably some improvements that can be made with this plugin, but I think it's already better than having to add a tonne of pylint disables, for uses of e.g. Entity.objects.
Naturally, if there are any replies to pylint-dev/pylint#1694 (comment), then I will update it.

@chrisjsewell
Copy link
Member Author

The other approach would be to turn it into a standalone package. I can do that but probably not today

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #5190 (b470559) into develop (78c7b72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5190   +/-   ##
========================================
  Coverage    81.00%   81.00%           
========================================
  Files          535      535           
  Lines        37402    37402           
========================================
  Hits         30293    30293           
  Misses        7109     7109           
Flag Coverage Δ
django 75.82% <ø> (ø)
sqlalchemy 74.92% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c7b72...b470559. Read the comment docs.

@sphuber
Copy link
Contributor

sphuber commented Oct 20, 2021

The other approach would be to turn it into a standalone package. I can do that but probably not today

That's what I was going to suggest. No need to do it today

@chrisjsewell
Copy link
Member Author

@chrisjsewell chrisjsewell changed the title 🔧 MAINTAIN: Move pylint plugin into aiida 🔧 MAINTAIN: Move pylint plugin to external package Oct 26, 2021
@chrisjsewell chrisjsewell merged commit ea3ab28 into aiidateam:develop Oct 26, 2021
@chrisjsewell chrisjsewell deleted the move-pylin-plugin branch October 26, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants