Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdline: show #procs/machine in verdi computer show #4945

Merged

Conversation

dev-zero
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #4945 (fe4008b) into develop (403f7e7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4945      +/-   ##
===========================================
- Coverage    80.06%   80.05%   -0.00%     
===========================================
  Files          515      515              
  Lines        36623    36611      -12     
===========================================
- Hits         29317    29305      -12     
  Misses        7306     7306              
Flag Coverage Δ
django 74.50% <100.00%> (-0.01%) ⬇️
sqlalchemy 73.43% <100.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/cmdline/commands/cmd_computer.py 80.73% <100.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403f7e7...fe4008b. Read the comment docs.

Copy link
Member

@ramirezfranciscof ramirezfranciscof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dev-zero , thanks! I don't know why CodeCov is complaining, this code should be tested by:

tests.cmdline.commands.test_computer::TestVerdiComputerCommands.test_computer_show

So the modified lines + new line should also be covered...🤷🏽‍♂️

EDIT: Well, not actually "complaining" (it's not blocking the PR) but it shows red lines in the coverage report...

@ramirezfranciscof ramirezfranciscof merged commit 773e944 into aiidateam:develop May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants