Bump base docker image version.

[yakutovicha]

fixes #4339

The new image is based on the latest stable Bionic Beaver (18.04)
Ubuntu distribution, which contains fixes for critical vulnerabilities.

Additionally, this image contains a fix for ruamel.yaml package
installation.

[greschd]

Thanks! Since (I think) this will only affect the latest tag, how are we fixing this for stable? Backporting this commit to the release branch? Just curious, you're the expert here :)

[yakutovicha]

Thanks! Since I think this will only affect the latest tag, how are we fixing this for stable? Backporting this commit to the release branch?

I can make a new docker image, tagged as 1.3.1.1 (based on AiiDA 1.3.1) or 1.3.0.2 (based on AiiDA 1.3.0).

[yakutovicha]

Thanks! Since I think this will only affect the latest tag, how are we fixing this for stable? Backporting this commit to the release branch?

I can make a new docker image, tagged as 1.3.1.1 (based on AiiDA 1.3.1) or 1.3.0.2 (based on AiiDA 1.3.0).

any preferences, or should I do both?

[greschd]

Probably the version based on AiiDA 1.3.1 (1.3.1.1) at least should be fixed, right? Not sure if the 1.3.0 - based one makes sense.. that also won't contain the bugfixes between 1.3.0 and 1.3.1.

For me it doesn't make much of a difference, I'm using these just for testing - there's nothing critical I rely on different between these versions.

[yakutovicha]

Probably the version based on AiiDA 1.3.1 (1.3.1.1) at least should be fixed, right? Not sure if the 1.3.0 - based one makes sense.. that also won't contain the bugfixes between 1.3.0 and 1.3.1.

For me it doesn't make much of a difference, I'm using these just for testing - there's nothing critical I rely on different between these versions.

Alright, then. I will build this updated image locally and push it to the DockerHub.

[greschd]

Probably a decent policy is always having one maintained image per maintained AiiDA release branch.

[codecov]

Codecov Report

Merging #4353 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4353      +/-   ##
===========================================
+ Coverage    79.28%   79.29%   +0.01%     
===========================================
  Files          468      468              
  Lines        34620    34620              
===========================================
+ Hits         27446    27447       +1     
+ Misses        7174     7173       -1     

Flag	Coverage Δ
#django	72.91% <ø> (ø)
#sqlalchemy	72.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiida/engine/daemon/runner.py	82.76% <0.00%> (+3.45%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c31bc2...1215406. Read the comment docs.

[yakutovicha]

@greschd both images (1.3.0.2 and 1.3.1.1) are pushed.

[greschd]

@yakutovicha I guess the stable tag should now point to 1.3.1.1? Or is that just automatically built from master and can't be changed otherwise?

[yakutovicha]

@yakutovicha I guess the stable tag should now point to 1.3.1.1? Or is that just automatically built from master and can't be changed otherwise?

The stable always points to the latest build at the master branch

[greschd]

I see - probably not worth it to cherry-pick that onto master, right? It would probably lead to a bit of a mess next time we merge develop into master.

[yakutovicha]

I see - probably not worth it to cherry-pick that onto master, right?

I think it is not worth. At least I don't see a clear advantage of doing it vs the mess it would create.

[greschd]

Agreed - since it's harder to update, I think we should advise (don't know where) people to prefer pinning specific tags (like 1.3.1.1) instead of the stable tag.