Introduce equality concept for nodes + tests #4352
Conversation
Two nodes will evaluate to be equal if their uuid coincides.
|
This is now WIP and paused, see this comment in issue #1917 |
| def test_equality(self): | ||
| """Test the `__eq__` method.""" | ||
| node1 = Node() | ||
| node2 = node1 |
There was a problem hiding this comment.
This test doesn't work quite as intended: Because node1 and node2 are the same Python object (id(node1) == id(node2)), node1 == node2 will be True even in the current code.
Instead, I think we need to store a Data node and load it back, such that node1 and node2 are different Python objects.
That can be tested by assert node1 is not node2.
There was a problem hiding this comment.
See the following (current behavior, before the applied fix):
In [1]: from aiida.orm import Data
In [2]: d1 = Data().store()
In [3]: d2 = d1
In [4]: d3 = load_node(d1.uuid)
In [5]: d1 == d2
Out[5]: True
In [6]: d1 is d2
Out[6]: True
In [7]: d1 == d3
Out[7]: False
In [8]: d1 is d3
Out[8]: FalseThere was a problem hiding this comment.
Thanks! I had a slight suspicion of this but I found the problems with the intrinsic python-mock node types before I could get to that. I would anyways have had to ask you guys how to check this for sure, haha.
|
After some discussion in the original issue #1917 I will be closing this down until we reach a final agreement and then I can implement a more thorough and complete solution. |
Two nodes will evaluate to be equal if their uuid coincides.
Fixes #1917