Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions/checkout@v2 (instead of @master) #3846

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

CasperWA
Copy link
Contributor

master was used due to actions/checkout@v2 not working with codecov/codecov-action@v1.

An issue was raised at actions/checkout#180

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #3846 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3846   +/-   ##
========================================
  Coverage    77.16%   77.16%           
========================================
  Files          458      458           
  Lines        33770    33770           
========================================
  Hits         26058    26058           
  Misses        7712     7712
Flag Coverage Δ
#django 69.2% <ø> (ø) ⬆️
#sqlalchemy 70.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733861a...d4cc35f. Read the comment docs.

@CasperWA
Copy link
Contributor Author

It seems to work, actions/checkout#180 can be closed.

@CasperWA CasperWA requested a review from csadorf March 12, 2020 15:53
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for checking @CasperWA !

@ltalirz ltalirz merged commit 1246553 into aiidateam:develop Mar 12, 2020
@CasperWA CasperWA deleted the use_checkout_v2 branch April 2, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants