Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set correct backend for quicksetup test #2954

Merged

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jun 2, 2019

hopefully fix #2950

Also opened a feature request for introducing key validation in click-config-file phha/click_config_file#11

@ltalirz
Copy link
Member Author

ltalirz commented Jun 2, 2019

As for why the tests may sometimes run: other quicksetup test functions were setting the correct backend (and we don't seem to be clearing the database in between tests here (?)), so the order may have made the difference.

@coveralls
Copy link

coveralls commented Jun 2, 2019

Coverage Status

Coverage remained the same at 72.877% when pulling 5f6e8be on ltalirz:issue_2950_quicksetup_backend_issue into 9abc39d on aiidateam:develop.

@ltalirz ltalirz requested a review from sphuber June 2, 2019 11:24
@ltalirz
Copy link
Member Author

ltalirz commented Jun 2, 2019

@sphuber would be good to merge this, since this can cause issues in many other PRs.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ltalirz , let's close the issue for now and we can reopen it if it still occurs

@sphuber sphuber merged commit ee6ee71 into aiidateam:develop Jun 2, 2019
@sphuber sphuber deleted the issue_2950_quicksetup_backend_issue branch June 2, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random failing tests verdi quicksetup on SqlAlchemy python 3
3 participants