Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the explicit dependency upper limit for scipy #1492

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 8, 2018

This was introduced when scipy 1.0.0 was released which broke the
build. Now that 1.0.1 is available, which fixes that issue, the
upper bound and explicit dependency is no longer needed.

This was introduced when scipy 1.0.0 was released which broke the
build. Now that 1.0.1 is available, which fixes that issue, the
upper bound and explicit dependency is no longer needed.
@sphuber sphuber requested a review from giovannipizzi May 8, 2018 07:24
@codecov-io
Copy link

Codecov Report

Merging #1492 into release_v0.12.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release_v0.12.1    #1492   +/-   ##
================================================
  Coverage            54.42%   54.42%           
================================================
  Files                  246      246           
  Lines                32454    32454           
================================================
  Hits                 17663    17663           
  Misses               14791    14791

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4569d8a...01c9421. Read the comment docs.

@giovannipizzi giovannipizzi merged commit 659bd6b into aiidateam:release_v0.12.1 May 8, 2018
@sphuber sphuber deleted the fix_remove_explicit_scipy_dependency branch May 8, 2018 07:47
@sphuber sphuber added this to the v0.12.1 milestone May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants