Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matplotlib dependency to setup requirements #1199

Closed
wants to merge 1 commit into from

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Feb 27, 2018

It cannot be in the 'docs' optional group, because then the
pre-commit hook won't pick it up to allow it in the requirements
text file for RTD, which then won't install it

It cannot be in the 'docs' optional group, because then the
pre-commit hook won't pick it up to allow it in the requirements
text file for RTD, which then won't install it
@ltalirz
Copy link
Member

ltalirz commented Feb 27, 2018

@sphuber Are you aware of this: #1144
(perhaps develop was not merged into workflows since?)

@giovannipizzi
Copy link
Member

Thanks Leo, I was looking for #1144 but couldn't find it (there are a few more PR about docs ;-) )
Maybe indeed it's enough to merge develop into workflows?

@sphuber
Copy link
Contributor Author

sphuber commented Feb 27, 2018

Thanks Leo, I wasn't aware of that issue. Giovanni notified me of the failing workflows builds and asked me to add matplotlib. So am I to understand that this was already fixed in develop? If so, I will close this and just merge develop into workflows and open a PR for that. I was planning on merging develop anyway

@ltalirz
Copy link
Member

ltalirz commented Feb 27, 2018

Yes, just merge develop and see whether the problem goes away

@sphuber sphuber closed this Feb 27, 2018
@sphuber sphuber deleted the fix_rtd_requirements branch February 27, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants