-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added a stock tracker component in kitchen-sink package #667
feat: added a stock tracker component in kitchen-sink package #667
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @Abhishek-Mallick, thank you for your PR. This looks good, but I have only two concerns.
Can you add a sentence that tells the user what a valid input is? You could also list some examples of stocks they can search for. And if the API also returns the company's name or any other info, can you display them to the user? You could even have a dropdown list of stocks or companies they can select, which is a more user-friendly approach than guessing the stock name or going to google to search for it. |
@Timonwa @tobySolutions
2023-10-05.21-16-42.mp4 |
Thank you very much for the review @Timonwa. Good job @Abhishek-Mallick; I'm reviewing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
This looks so much better @Abhishek-Mallick. Awesome job. 👍🏽 |
Please describe the changes this PR makes and why it should be merged:
This PR aims to demonstrate a stock tracker component using million incorporated with a
alphavantage api
Status
Closes : #611
2023-10-05.14-06-58.mp4
Semantic versioning classification: