Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen Sink: Build A Memory Game added #661

Closed
wants to merge 13 commits into from
Closed

Kitchen Sink: Build A Memory Game added #661

wants to merge 13 commits into from

Conversation

sr2005roy
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
issue: #609
added Kitchen Sink: Build A Memory Game using million,js and react. Hope you like it :)
closes: Kitchen Sink: Build A Memory Game
images::
Screenshot 2023-10-03 191003
Screenshot 2023-10-03 191153
Screenshot 2023-10-03 191124

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 0:27am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 0:27am

@sr2005roy
Copy link
Contributor Author

Please check and merge the PR :)

@tobySolutions
Copy link
Contributor

Hey @sr2005roy. Thanks. for this! Can you maybe remove the css file and move all your styling to the style.css? Feel free to use comments to separate out your own styling.

@tobySolutions
Copy link
Contributor

Also, your images are not coming up. Have you considered deploying them somewhere?

@sr2005roy
Copy link
Contributor Author

That's what which gave conflict last time

@tobySolutions
Copy link
Contributor

That's what which gave conflict last time

Hmm, I don't understand.

@sr2005roy
Copy link
Contributor Author

made the changes :)

@tobySolutions
Copy link
Contributor

made the changes :)

Awesome! Checking it out now.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6412289205

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6412019171: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@sr2005roy
Copy link
Contributor Author

is everything good ??

@tobySolutions
Copy link
Contributor

Um, I think something else is wrong:

Uploading Screen Recording 2023-10-04 at 23.45.22.mov…

@tobySolutions
Copy link
Contributor

Screen.Recording.2023-10-04.at.23.45.22.mov

@sr2005roy
Copy link
Contributor Author

sr2005roy commented Oct 4, 2023

@tobySolutions
is the issue corrected at your side?
please check once :)

@tobySolutions
Copy link
Contributor

I think instead of using relative paths to the images, you should try using absolute paths instead

@sr2005roy
Copy link
Contributor Author

sr2005roy commented Oct 5, 2023

Solved all the bugs
resolved conflicts which appaired
Also added the reset button

WhatsApp.Video.2023-10-05.at.22.23.56_6cf573de.mp4

@tobySolutions @Timonwa
Hopefully it works well and you like it :)
Kindly merge the PR under hactoberfest-accepted label

@sr2005roy sr2005roy closed this Oct 6, 2023
@sr2005roy sr2005roy reopened this Oct 6, 2023
@sr2005roy
Copy link
Contributor Author

sr2005roy commented Oct 6, 2023

Kindly check I have resolved all the conflicts
@Timonwa @tobySolutions :)

@tobySolutions
Copy link
Contributor

Hey @sr2005roy, can you maybe resolve your merge conflicts, please? Thank you!

@sr2005roy
Copy link
Contributor Author

Done bro
Its actually arising as many new merges are been performed so style.css gets conflicts.
Please have a look at this PR :)
@tobySolutions

@tobySolutions
Copy link
Contributor

Hey there, you seem to still have conflicts and I tried resolving them, but, I think I broke it @sr2005roy; could you just please make another PR?

@Timonwa
Copy link
Contributor

Timonwa commented Oct 8, 2023

Hi @sr2005roy, the issues were resolved and the game working right, which is great, but sadly, Tobi couldn't resolve it. Pls, don't feel discouraged, to open a new PR again. ❤️ 🫂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A Memory Game
4 participants