-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kitchen Sink: Build A Memory Game added #661
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Please check and merge the PR :) |
Hey @sr2005roy. Thanks. for this! Can you maybe remove the css file and move all your styling to the style.css? Feel free to use comments to separate out your own styling. |
Also, your images are not coming up. Have you considered deploying them somewhere? |
That's what which gave conflict last time |
Hmm, I don't understand. |
made the changes :) |
Awesome! Checking it out now. |
Pull Request Test Coverage Report for Build 6412289205
💛 - Coveralls |
is everything good ?? |
Um, I think something else is wrong: Uploading Screen Recording 2023-10-04 at 23.45.22.mov… |
Screen.Recording.2023-10-04.at.23.45.22.mov |
@tobySolutions |
I think instead of using relative paths to the images, you should try using absolute paths instead |
Solved all the bugs WhatsApp.Video.2023-10-05.at.22.23.56_6cf573de.mp4@tobySolutions @Timonwa |
Kindly check I have resolved all the conflicts |
Hey @sr2005roy, can you maybe resolve your merge conflicts, please? Thank you! |
Done bro |
Hey there, you seem to still have conflicts and I tried resolving them, but, I think I broke it @sr2005roy; could you just please make another PR? |
Hi @sr2005roy, the issues were resolved and the game working right, which is great, but sadly, Tobi couldn't resolve it. Pls, don't feel discouraged, to open a new PR again. ❤️ 🫂 |
Please describe the changes this PR makes and why it should be merged:
issue: #609
added Kitchen Sink: Build A Memory Game using million,js and react. Hope you like it :)
closes: Kitchen Sink: Build A Memory Game
images::
Status
Semantic versioning classification: