Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): replace wizard with @million/install #1034

Merged
merged 2 commits into from
May 21, 2024

Conversation

xinyao27
Copy link
Collaborator

Please describe the changes this PR makes and why it should be merged:

Replaced the original wizard with @million/install.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@xinyao27 xinyao27 requested a review from aidenybai May 20, 2024 15:51
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 9:03am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 9:03am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9171917780

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 3.966%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/cli/src/index.ts 0 2 0.0%
packages/cli/build.mjs 0 3 0.0%
Totals Coverage Status
Change from base Build 9145559693: 0.1%
Covered Lines: 987
Relevant Lines: 27384

💛 - Coveralls

@aidenybai aidenybai merged commit b7e11be into aidenybai:main May 21, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants