Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.0 #21

Closed
wants to merge 27 commits into from
Closed

v1.4.0 #21

wants to merge 27 commits into from

Conversation

aidanmelen
Copy link
Owner

@aidanmelen aidanmelen commented Oct 7, 2022

Fixes

Proposed Changes

  • adding unpack variable Prevent Service Interruption during rule updates #22
    • implemented by null_unpack_rules sub-module.
  • add variable validation for ingress, egress, matrix_ingress, matrix_egress, computed_ingress,
    computed_egress, computed_matrix_ingress, and computed_matrix_egress.
  • added debug variable to better understand the looping local data structures.
  • added count checks to terratest.

Service Interruption Warning

There are two scenarios that will cause security group rule replacement during the upgrade:

  1. With the unpack enhancement, we now normalize the rules (i.e. looking up managed and common rules values) before creating the map keys. Keys will now have a predefined order. As a consequence, existing ingress, egress, matrix_ingress, and matrix_egress module rules, for versions v1.3.0 and earlier, will be replaced when upgrading to v1.4.0. This doesn't warrant a major release because the all module versions v1.3.0 and earlier constantly suffer from the side-effect caused by packing rule arguments. Therefore, the service interruption is common and accepted. Upgrading will prevent it from happening again after the upgrade.
  2. Rules that use managed or common (aliased rules) and do not have a description override will see the rule with the managed by Terraform description be replaced with the new alias rule descriptions. For aliased rules that are overriding the default description will not be replaced.

@aidanmelen aidanmelen added the enhancement New feature or request label Oct 7, 2022
@aidanmelen aidanmelen changed the title V2.0.0 V1.4.0 Oct 7, 2022
@aidanmelen aidanmelen changed the title V1.4.0 V2.0.0 Oct 7, 2022
@aidanmelen aidanmelen changed the title V2.0.0 v1.4.0 Oct 7, 2022
@aidanmelen aidanmelen self-assigned this Oct 7, 2022
@aidanmelen aidanmelen linked an issue Oct 8, 2022 that may be closed by this pull request
@aidanmelen aidanmelen linked an issue Oct 8, 2022 that may be closed by this pull request
@aidanmelen aidanmelen marked this pull request as draft October 9, 2022 18:07
@aidanmelen aidanmelen closed this Oct 10, 2022
@aidanmelen aidanmelen deleted the v1.4.0 branch October 10, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed and Common rules are missing default description Prevent Service Interruption during rule updates
1 participant