-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.4.0 #21
Closed
Closed
v1.4.0 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oy lifecycle for sg rules.
…eate rules with single source/destination to work with the new rule.key optional argument.
… unpack example for initial testing.
…tion/example for the null-unpack-aws-security-group-rules sub-module.
…module. added debug variable. added descriptions to rule aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
anytrue
support.null_repack_matrix_rules
sub-module to simplifymatrix.tf
Proposed Changes
unpack
variable Prevent Service Interruption during rule updates #22null_unpack_rules
sub-module.ingress
,egress
,matrix_ingress
,matrix_egress
,computed_ingress
,computed_egress
,computed_matrix_ingress
,and computed_matrix_egress
.debug
variable to better understand the looping local data structures.Service Interruption Warning
There are two scenarios that will cause security group rule replacement during the upgrade:
unpack
enhancement, we now normalize the rules (i.e. looking up managed and common rules values) before creating the map keys. Keys will now have a predefined order. As a consequence, existingingress
,egress
,matrix_ingress
, andmatrix_egress
module rules, for versions v1.3.0 and earlier, will be replaced when upgrading to v1.4.0. This doesn't warrant a major release because the all module versions v1.3.0 and earlier constantly suffer from the side-effect caused by packing rule arguments. Therefore, the service interruption is common and accepted. Upgrading will prevent it from happening again after the upgrade.managed by Terraform
description be replaced with the new alias rule descriptions. For aliased rules that are overriding the default description will not be replaced.