Allow synchronous call tags to work inside redirects #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to include synchronous object macro calls inside of redirects (both the command and inline form).
This fixes #201.
Example from the unit test:
This is similar to the bug fix in #111 when object macros were fixed for conditional commands. It only supports synchronous macros (ones which return a string reply, not a promise) for the same reason.
In order to avoid regular expression problems with the
{@...}
syntax's curly brackets conflicting with those from the mangled{__call_arg__}
types of tags, I changed the delimiter of the mangled call tags to use the 'LEFT-POINTING DOUBLE ANGLE QUOTATION MARK' (U+00AB) and 'RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK' (U+00BB)' symbols:«
and»
. I chose these symbols so that if the call tag fails to parse properly (as it did in the original bug), the resulting text contains printable symbols.«
and»
are not used by anything else in RiveScript.