Fix variable names and unused arguments #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elynnwu
reviewed
Dec 8, 2022
| @@ -571,14 +572,13 @@ def heat_source_from_vorticity_damping( | |||
| ubt, vbt, gx, gy, rsin2, cosa_s, u2, v2, du2, dv2 | |||
| ) | |||
| heat_source = delp * ( | |||
| heat_source - 0.25 * kinetic_energy_fraction_to_damp * dampterm | |||
| heat_source - kinetic_energy_fraction_to_damp * dampterm | |||
There was a problem hiding this comment.
I don't remember why we're removing this 0.25?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes many small issues. In particular, cases of renaming variables and objects, removing unused arguments, and removing index arguments in favor of dimension names.
The commit history should be referenced for details of changes. This PR should be reviewed commit-by-commit and merged without squashing to preserve history.
Checklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updated