Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move util docs, install instructions into top level docs #380

Merged
merged 15 commits into from
Nov 22, 2022
Merged

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Nov 10, 2022

Purpose

This PR moves the documentation for pace-util into the top level of the repo, and copies install instructions from the README into the sphinx docs (to be deleted from the README later when we can link to the sphinx docs).

Changes:

  • Added doctest plan to circleci
  • Moved util documentation to top-level sphinx docs
  • Added halo update walkthrough to sphinx docs
  • Moved linting on CircleCI to small resource type

@mcgibbon mcgibbon changed the title Move util docs to top level, include install instructions in sphinx docs Move util docs, install instructions into top level docs Nov 10, 2022
$ python3 -m venv venv_name
$ source venv_name/bin/activate

Inside of your pace `venv` or conda environment pip install the Python requirements, GT4Py, and Pace:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention installing lint and docs with just different requirement name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Communication
=============

As mentioned when discussing :ref:`State`, each process or "rank" on a cubed sphere is responsible for a subset of the cubed sphere grid.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to State is not showing up when I build it locally, is something missing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, fixed by adding manual anchors to the missing pages.


.. doctest::

>>> quantity.view[:] = np.arange(4)[None, :] + np.arange(4)[:, None]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something like np.arange(4)[None, :] + 2*np.arange(4)[:, None] so that there isn's two repeated [3,4,5,6] for the example?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to ones and tens.

State can be persisted to disk using either :py:func:`pace.util.write_state` (described below)
or :py:class:`pace.util.ZarrMonitor`. The latter will coordinate between ranks to
write state to a unified Zarr store. Initializing it requires passing grid information.
State can be persisted to disk using either :py:func:`pace.util.write_state` (described below) or :py:class:`pace.util.ZarrMonitor`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add netcdf monitor too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Collaborator

@elynnwu elynnwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcgibbon mcgibbon enabled auto-merge (squash) November 14, 2022 22:26
@mcgibbon
Copy link
Collaborator Author

launch jenkins

@mcgibbon mcgibbon disabled auto-merge November 22, 2022 19:48
@mcgibbon mcgibbon merged commit e7a0ede into main Nov 22, 2022
@mcgibbon mcgibbon deleted the docs/util branch November 22, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants