Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare fv3net for open sourcing #1090

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Prepare fv3net for open sourcing #1090

merged 3 commits into from
Mar 17, 2021

Conversation

nbren12
Copy link
Contributor

@nbren12 nbren12 commented Mar 17, 2021

I cherry-picked the relevant changes from #986. We can upgrade to python 3.7 and the newer cftime/xarray at a later date.

Resolves #920.

@nbren12 nbren12 enabled auto-merge (rebase) March 17, 2021 19:07
oliverwm1
oliverwm1 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@oliverwm1 oliverwm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Side note: is there something non-deterministic about generating the constraints.txt file? Or does it depend on local env? There are a few packages that seem to appear and disappear depending on who touched it last.

@nbren12 nbren12 mentioned this pull request Mar 17, 2021
Closed
@nbren12 nbren12 merged commit 5d06224 into master Mar 17, 2021
@nbren12 nbren12 deleted the open-sourcing branch March 17, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverwm1 oliverwm1 oliverwm1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public release of fv3net
2 participants
@nbren12 @oliverwm1