feat: don't require .env to exist #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
changed the title
monilpat
reviewed
Nov 20, 2024
| // Load the .env file | ||
| const result = config({ path: envPath }); | ||
| // attempt to Load the .env file into process.env | ||
| const result = config(envPath ? { path: envPath } : {}); |
There was a problem hiding this comment.
Confirming that config({}) doesn't cause any errors?
There was a problem hiding this comment.
It does not, I checked
|
FYI: There is another approach to agent specific envs added in: #410 still via env but in a segmented way. |
|
I saw that, complementary to this. Wasn't sure if that's going to get merged so left it out of this description |
|
Awesome - re comments. Yeah totally makes sense. Feel free to add a quick
note in the README about .env files being optional. I know it may cause
merge conflicts between these 2 PRs, but it does seem important to have!
Thanks for doing this :)
…On Tue, Nov 19, 2024 at 7:02 PM Odilitime ***@***.***> wrote:
I saw that, complementary to this. Wasn't sure if that's going to get
merged so left it out of this description
—
Reply to this email directly, view it on GitHub
<#427 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADS6ROIFKY3GDMIXH2FIZPT2BP3S5AVCNFSM6AAAAABSDQRNZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBXGI2DKMJZHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Looks like the limitations are: feat|fix|docs|style|refactor|test|chore:any description see |
odilitime
changed the title
|
LGTM! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Medium, haven't discussed this widely
Background
What does this PR do?
Removes the requirement for .env to exists
What kind of change is this?
Improvement
Why are we doing this? Any context or related work?
Large multiagent instances will have to rely on character.json to have all the settings and secrets for that agent. Have a default .env in these instances to set defaults might be helpful but also hurtful. This allows the admin to choose if they want any defaults across all their agents or nots.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Ran against stable-11-17 branch without issue