Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dependencies support #240

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

edouardmenayde
Copy link
Contributor

Currently if you install size-limit presets in your as optional dependency (mainly useful not to download chromium if you don't need to in your CI using --no-optional) then size-limit will not find plugins.
This PR adds this feature.

@ai ai merged commit 3b9b7ec into ai:main Jul 26, 2021
@edouardmenayde edouardmenayde deleted the feature/optional-dependencies-support branch July 26, 2021 15:33
@ai
Copy link
Owner

ai commented Jul 26, 2021

Will it work if user will not install plugin from optional dependency?

@edouardmenayde
Copy link
Contributor Author

Yes it will, thanks for merging so quickly !

@ai
Copy link
Owner

ai commented Jul 26, 2021

Thanks. Released in 5.0.2.

@edouardmenayde
Copy link
Contributor Author

You rock, thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants