Skip to content

Commit

Permalink
Remove @napi-rs/uuid to fix CI
Browse files Browse the repository at this point in the history
  • Loading branch information
ai committed Feb 14, 2022
1 parent defe20f commit ee7dee3
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 136 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,4 @@ jobs:
- name: Install dependencies
run: pnpm install --frozen-lockfile --ignore-scripts
- name: Run benchmark
run: pnpm run benchmark
run: node ./test/benchmark.js
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
"clean": "rm -R coverage",
"unit": "uvu . .test.js$",
"test": "c8 pnpm unit && eslint . && pnpm clean && size-limit",
"start": "vite test/demo/ --open",
"benchmark": "node ./test/benchmark.js"
"start": "vite test/demo/ --open"
},
"engines": {
"node": "^10 || ^12 || ^13.7 || ^14 || >=15.0.1"
Expand All @@ -36,7 +35,6 @@
"@babel/core": "^7.17.2",
"@logux/eslint-config": "^46.1.1",
"@lukeed/uuid": "^2.0.0",
"@napi-rs/uuid": "^0.2.0",
"@originjs/vite-plugin-commonjs": "^1.0.2",
"@size-limit/dual-publish": "^7.0.8",
"@size-limit/file": "^7.0.8",
Expand Down
128 changes: 0 additions & 128 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions test/benchmark.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

let { uid: uidSecure } = require('uid/secure')
let { v4: lukeed4 } = require('@lukeed/uuid')
let { v4: napiv4 } = require('@napi-rs/uuid')
let { v4: uuid4 } = require('uuid')
let benchmark = require('benchmark')
let shortid = require('shortid')
Expand Down Expand Up @@ -33,9 +32,6 @@ suite
.add('crypto.randomUUID', () => {
crypto.randomUUID()
})
.add('@napi-rs/uuid', () => {
napiv4()
})
.add('uid/secure', () => {
uidSecure(32)
})
Expand Down

1 comment on commit ee7dee3

@ai
Copy link
Owner Author

@ai ai commented on ee7dee3 Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brooooooklyn I got to have `` error on CI https://github.com/ai/nanoid/runs/5190655849?check_suite_focus=true

I removed @napi-rs/uuid to fix this issue.

If you know a way to fix it properly, please send another PR.

Please sign in to comment.