Fix links to atom jobs in the atom state renderers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without using the UrlHelper, the link to _Atom details_ could be wrong and lead to HTTP 404 errors. For example, it would point to http://localhost:5000/jobs/atoms/10119 instead of http://localhost:5000/hangfire/jobs/atoms/10119 when using the default `app.UseHangfireDashboard()` method that maps the Hangfire dashboard on `/hangfire`.
|
Hi there, thanks for contribution! |
|
I just found way, without using reflection, to get the It should be much safer! |
|
Wow! Looks good to me, let me test it before pushing to live. |
ahydrax
approved these changes
Dec 9, 2022
|
Thanks for merging. And I see that version 0.4.4 is already released, awesome! 🥳 |
|
For the record: the I'll open a new pull request to simplify the current implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without using the UrlHelper, the link to Atom details could be wrong and lead to HTTP 404 errors.
For example, it would point to http://localhost:5000/jobs/atoms/10119 instead of http://localhost:5000/hangfire/jobs/atoms/10119 when using the default
app.UseHangfireDashboard()method that maps the Hangfire dashboard on/hangfire.