Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPROVE: Remove Gulp Global Dependency by using NPM Scripts #83

Merged
merged 2 commits into from
Jan 14, 2018
Merged

IMPROVE: Remove Gulp Global Dependency by using NPM Scripts #83

merged 2 commits into from
Jan 14, 2018

Conversation

JeremyEnglert
Copy link
Collaborator

Description

Added NPM scripts to package.json so users do not have to install Gulp globally.

Screenshots:

screen shot 2018-01-13 at 4 43 36 pm

screen shot 2018-01-13 at 4 45 59 pm

screen shot 2018-01-13 at 4 46 49 pm

screen shot 2018-01-13 at 4 48 19 pm

screen shot 2018-01-13 at 4 48 52 pm

screen shot 2018-01-13 at 4 49 13 pm

screen shot 2018-01-13 at 4 49 50 pm

Types of changes

Tasks must be run using npm run taskName.

  • gulp becomes npm run start
  • gulp styles becomes npm run styles
  • gulp vendorsJS becomes npm run vendorsJS
  • gulp customJS becomes npm run customJS
  • gulp images becomes npm run images
  • gulp clearCache becomes npm run clearCache
  • gulp translate becomes npm run translate

How Has This Been Tested?

Each task was run using the new npm run format. Screenshots can be seen above.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has extensive inline documentation like the rest of WPGulp.

ahmadawais
ahmadawais approved these changes Jan 14, 2018
View reviewed changes
Copy link
Owner

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🔥

@ahmadawais ahmadawais merged commit d194d35 into ahmadawais:v2.0.0 Jan 14, 2018
@ahmadawais
Copy link
Owner

Thanks for this @JeremyEnglert —getting better 👍

@JeremyEnglert JeremyEnglert mentioned this pull request Jan 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadawais ahmadawais ahmadawais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyEnglert @ahmadawais