Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Get latest APK version #182

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Bugfix: Get latest APK version #182

merged 3 commits into from
Aug 19, 2022

Conversation

Der-Henning
Copy link
Contributor

Updated the RegEx to obtain the latest APK Version.

@ahivert
Copy link
Owner

ahivert commented Aug 19, 2022

Thank you !
I should have added a test for this one :/

Is it possible for you to add one ?

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #182 (f3c4209) into master (1b575a7) will increase coverage by 1.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   77.84%   79.74%   +1.89%     
==========================================
  Files           3        3              
  Lines         158      158              
  Branches       23       23              
==========================================
+ Hits          123      126       +3     
+ Misses         34       31       -3     
  Partials        1        1              
Impacted Files Coverage Δ
tgtg/google_play_scraper.py 100.00% <ø> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Der-Henning
Copy link
Contributor Author

Der-Henning commented Aug 19, 2022

Hi. I added a test that simply checks if the function get_last_apk_version raises an error or not.

@ahivert ahivert merged commit cc58615 into ahivert:master Aug 19, 2022
@ahivert
Copy link
Owner

ahivert commented Aug 19, 2022

thanks ! new release 0.13.1 has been published on pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants