update to latest ssb-server (again) #20
Conversation
| @@ -122,7 +141,7 @@ from GitHub: | |||
| ```shell | |||
| git clone https://github.com/ahdinosaur/ssb-pub.git | |||
| cd ssb-pub | |||
| docker build -t ssb-pub . | |||
| docker build -t ahdinosaur/ssb-pub . | |||
There was a problem hiding this comment.
This doesn't make sense for users. Accidental change?
There was a problem hiding this comment.
hi @timjrobinson, this is on purpose, as you need to build an image with the same name as will be used in ./create-sbot, unless you change the image name there. even though it's namespaced with ahdinosaur, anyone should be able to build an image with that name, just not publish the image.
i made this change because when i first tested #19, i ran docker build -t ssb-pub then created a container with ahdinosaur/ssb-pub, so was actually running the old image and mistakenly thought the new image worked.
with the context, does this seem like an okay change?
There was a problem hiding this comment.
Ah ok that makes sense to keep the scripts and documentation consistent no matter where you get the image from.
Dockerfile
Outdated
| @@ -11,13 +11,13 @@ ENV PATH=/home/node/.npm-global/bin:$PATH | |||
| ENV NPM_CONFIG_PREFIX=/home/node/.npm-global | |||
|
|
|||
| USER node | |||
| RUN npm install -g [email protected]2 | |||
| RUN npm install -g [email protected].2 | |||
|
|
|||
| EXPOSE 8008 | |||
|
|
|||
| HEALTHCHECK --interval=30s --timeout=30s --start-period=10s --retries=10 \ | |||
| CMD sbot whoami || exit 1 | |||
There was a problem hiding this comment.
ssb-server still exports the sbot command, this is me being lazy but it should work.
There was a problem hiding this comment.
Isn't using sbot deprecated? IIRC it throws a warning when used. Might as well change it to set a good example for the community.
| @@ -11,13 +11,13 @@ ENV PATH=/home/node/.npm-global/bin:$PATH | |||
| ENV NPM_CONFIG_PREFIX=/home/node/.npm-global | |||
|
|
|||
| USER node | |||
| RUN npm install -g [email protected] | |||
|
Thanks for fixing this! This works for me after applying the changes I mentioned. |
the last update didn't go so well, turns out this is a BREAKING CHANGE and pub owners will need to make some manual changes, i even tried to revert and then i ran into the errors that others have been encountering (#13, #15)
if anyone wants to help test this pull request (especially verifying my documentation changes are correct and helpful), that'd be rad! 😺
for a pub owner to update to the version in this pull request:
git clone https://github.com/ahdinosaur/ssb-pubcd ssb-pubgit checkout ssb-serverdocker build -t ahdinosaur/ssb-pub .docker stop sbotdocker rm sbot~/ssb-pub-data/configusing the documentation in this pull request./create-sbotusing the documentation in this pull request./create-sbotcheck things are working with
docker logs sbotand./sbot whoami🌔