v3 #20
Closed
v3 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case you want to listen to more than just actions, this change allows your app `run` function to listen to all the streams returned by `inu.start`.
BREAKING CHANGE: rename streams to sources also add effectActionSink as last arg to `run` function
Current coverage is 100%@@ master #20 diff @@
===================================
Files 4 4
Lines 57 70 +13
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 57 70 +13
Misses 0 0
Partials 0 0
|
|
oops, wrong branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #19, here are the changes i've made writing
inu-plays-roguelike:pull-notify.listen)streamsreturned bystarttosourcesrunfunction receivessources(as returned bystart) instead ofactions.runfunction receivessink(the same sink where actions fromrunare drained) as last argument