Fixed generic aliases not passing checks against `type` #433

fefe982 · 2024-01-24T06:26:18Z

fixes #432

is_class(dict[str,str], type) returns False after python 3.11. Use isinstance(dict[str, str], types.GenericAlias) to check in this situation.

for more information, see https://pre-commit.ci

coveralls · 2024-01-24T06:27:23Z

coverage: 97.894% (+0.003%) from 97.891%
when pulling dbcc303 on fefe982:fix_type
into d481a51 on agronholm:master.

tests/test_checkers.py

for more information, see https://pre-commit.ci

agronholm · 2024-03-23T12:43:28Z

Thanks!

fefe982 and others added 2 commits January 24, 2024 14:17

fix: generic aliases should be type

9105400

[pre-commit.ci] auto fixes from pre-commit.com hooks

1198938

for more information, see https://pre-commit.ci

agronholm reviewed Jan 26, 2024

View reviewed changes

tests/test_checkers.py Outdated Show resolved Hide resolved

fefe982 and others added 5 commits January 29, 2024 11:46

check for generics in typing

4bb6ed7

[pre-commit.ci] auto fixes from pre-commit.com hooks

fe13f6e

for more information, see https://pre-commit.ci

Merge branch 'master' into fix_type

1f47446

Refined the checks and their tests

1ee3625

Corrected the phrasing of the changelog entry

dbcc303

agronholm changed the title ~~fix: generic aliases should be type~~ Fixed generic aliases not passing checks against type Mar 23, 2024

agronholm merged commit 2df6f4a into agronholm:master Mar 23, 2024
10 checks passed

Provide feedback