Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render table comments #109

Merged
merged 12 commits into from
Mar 12, 2020
Merged

Conversation

dhirschfeld
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 11, 2020

Coverage Status

Coverage increased (+0.1%) to 91.296% when pulling ff1f3ce on dhirschfeld:table-comments into b382448 on agronholm:master.

@dhirschfeld
Copy link
Contributor Author

The new(-ish) column comments feature is fantastic! ❤️

...so much so that I'd really like for table comments to also be reflected. Unfortunately when fa3c4a9 was merged the table comment feature from #92 wasn't also ported over.

This PR just includes the missing table comment support from #92.

@dhirschfeld
Copy link
Contributor Author

Looks like the only failure on py38 is unrelated:

Setting environment variables from .travis.yml
$ export TOXENV=py38
0.00s$ source ~/virtualenv/python3.8-dev/bin/activate
$ python --version
Python 3.8.1+
$ pip --version
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.8-dev/bin/pip", line 6, in <module>
    from pip._internal.cli.main import main
ModuleNotFoundError: No module named 'pip'
0.02s$ pip install tox
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.8-dev/bin/pip", line 6, in <module>
    from pip._internal.cli.main import main
ModuleNotFoundError: No module named 'pip'
The command "pip install tox" failed and exited with 1 during .

@dhirschfeld
Copy link
Contributor Author

So, that didn't fix it:

Setting environment variables from .travis.yml
$ export TOXENV=py38
0.00s$ source ~/virtualenv/python3.8-dev/bin/activate
$ python --version
Python 3.8.1+
$ pip --version
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.8-dev/bin/pip", line 6, in <module>
    from pip._internal.cli.main import main
ModuleNotFoundError: No module named 'pip'
0.02s$ python -m pip install tox
/home/travis/virtualenv/python3.8-dev/bin/python: No module named pip

Was worth a try I guess.

@dhirschfeld
Copy link
Contributor Author

Looks like others are running into problems with travis too:
https://gitter.im/python-trio/general?at=5e424170f3718e705df566f7

@dhirschfeld
Copy link
Contributor Author

Test at least seems to work locally:
image

@dhirschfeld
Copy link
Contributor Author

Hopefully it's fixed now:
pypa/virtualenv#1545 (comment)

@dhirschfeld
Copy link
Contributor Author

Ping @agronholm! CI (and coverage) now pass 🎉

It would be great to get this in so as to have self-documenting models.

tests/test_codegen.py Outdated Show resolved Hide resolved
@agronholm
Copy link
Owner

I'll merge this if you fix the remaining errors.

@dhirschfeld
Copy link
Contributor Author

All green!

@agronholm agronholm merged commit e9e5fd3 into agronholm:master Mar 12, 2020
@agronholm
Copy link
Owner

Thanks!

@dhirschfeld
Copy link
Contributor Author

Thank you @agronholm!

@dhirschfeld dhirschfeld deleted the table-comments branch March 12, 2020 07:03
ahardjasa pushed a commit to alloytech/sqlacodegen that referenced this pull request Aug 30, 2021
CF92 pushed a commit to alloytech/sqlacodegen that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants