-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monkeypatch apport excepthook #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on't need a separate run
Pull Request Test Coverage Report for Build 6709099173
💛 - Coveralls |
agronholm
requested changes
Oct 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly okay, just a few nits.
One more thing: please add a changelog entry. |
Done 👍 |
agronholm
approved these changes
Oct 31, 2023
8 tasks
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly just copies over code from trio, that had logic for making sure
MultiError
s got printed despiteapport
messing withsys.__excepthook__
. I'm planning to clean up the test code a bit more, and could move it intotest_formatting
if you want.I added the
-s
to pytest in CI to help debugging, but I'll remove it again unless you like verbose tests.Don't love the
traceback.TraceBackException
patch code duplication, should probably move that into a separate helper function or something. It could maybe also live outside the if statements (?).I left the messy commit history I racked up in jakkdl#1 in case you want to see test runs where it failed without the patch.