-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trio 0.15 warnings #106
Conversation
Diff looks plausible to me. You have test failures though, and GitHub isn't letting me see the logs on my phone, so maybe everything is broken, I dunno :-) I'm curious why anyio needs to subclass |
Because the |
|
anyio/_backends/_trio.py
Outdated
@@ -2,11 +2,11 @@ | |||
from types import TracebackType | |||
from typing import Callable, Optional, List, Type, Union | |||
|
|||
import trio.hazmat | |||
import trio.lowlevel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module does not exist in trio before v0.15. It would be better to use a conditional import for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. (For some values of "done" …)
OK, the Lock argument was missing. No longer testing against Py3.5 with Trio 0.15 should probably be fixed by somebody more familiar with the test setup. |
Not my problem either, I'm afraid … |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
not strictly required, but added for consistency
Trio 0.15.0 no longer supports Python 3.5, what is AnyIO's policy here? |
AnyIO 1.x still supports py3.5 but AnyIO 2.0 (in development) has dropped support. I will look at modifying the test suite to skip trio testing on py3.5. |
Thanks! |
No description provided.