Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14 ports #98

Merged
merged 11 commits into from
Apr 26, 2023
Merged

V14 ports #98

merged 11 commits into from
Apr 26, 2023

Conversation

agritheory
Copy link
Owner

No description provided.

@agritheory agritheory requested a review from HKuz April 24, 2023 16:57
@HKuz
Copy link
Collaborator

HKuz commented Apr 25, 2023

Two things that came up in testing:

  • The docs for "Company Discretionary Data" field for ACH Settings says it should show in the batch header, but I didn't see the text I used in the NACHA file (for comparison, the "ACH Description" text, which also says it goes in the batch header, showed up fine)
  • I accidentally selected an on-hold invoice to pay, and rightfully got an error and the banner up top that says "This Check Run has Errors click to view". But there doesn't seem to be any way to escape out of the Check Run, fix the errors, or start a new one (it shows the "Check Run XXXX is still processing..." warning on a new Run and won't let me edit anything - which makes sense if a large run is processing, but this one will never 'submit' and escape that state). There was also a pymysql.err.OperationalError: (1305, 'SAVEPOINT process_check_run does not exist') error, but that seems to tie to the disabled saving in the submitting state.

@agritheory
Copy link
Owner Author

I accidentally selected an on-hold invoice to pay

Ah, let me test this scenario, it should revert to draft. The API for savepoint has changed in v14, which took hours to figure out.

@agritheory
Copy link
Owner Author

@HKuz I believe I have fixed both issues, please review

Copy link
Collaborator

@HKuz HKuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants