Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Canadian regionalization #45

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Conversation

HKuz
Copy link
Collaborator

@HKuz HKuz commented Feb 3, 2023

Adds translation files to accommodate Canadian/en-GB spellings and terminology for the Check Run app. Also adds a validation step for DFI Routing Numbers (aba_number) to not exceed 8 characters for Banks with at least one Canadian address associated with it. (One confounding factor is that you can have more than one address associated with a bank).

Addresses #28 for version-14

Testing takeaways:

  • A user with English (Great Britain) as their language in settings -> translations loaded automatically and worked great
  • A user with English (generic, not GB or US) -> no translations picked up. Appears that Frappe code ignores en language and never loads the .csv translations. We may need to overwrite their code to get this setting to translate
  • One spot I couldn't get the translation to pick up was the text in the buttons in the dialog box to re-print checks
  • Not critical, but it looks like f-strings potentially aren't supported. There's only one that references ABA Number when it's missing and the NACHA file is built, but in the UI it shows as a full Traceback error vs a nice popup with text

@agritheory agritheory merged commit 6e9c977 into version-14 Feb 15, 2023
@agritheory agritheory deleted the can_regionalization branch February 15, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants