Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds translation files to accommodate Canadian/en-GB spellings and terminology for the Check Run app. Also adds a validation step for DFI Routing Numbers (
aba_number
) to not exceed 8 characters for Banks with at least one Canadian address associated with it. (One confounding factor is that you can have more than one address associated with a bank).Addresses #28 for version-14
Testing takeaways:
English (Great Britain)
as their language in settings -> translations loaded automatically and worked greatEnglish
(generic, not GB or US) -> no translations picked up. Appears that Frappe code ignoresen
language and never loads the .csv translations. We may need to overwrite their code to get this setting to translate