Fix payment schedule outstanding #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fproldan
reviewed
Jun 18, 2024
| ], | ||
| "on_submit": ["check_run.overrides.payment_entry.update_check_number"], | ||
| "on_submit": [ | ||
| "check_run.overrides.payment_entry.update_outstanding_amount", |
There was a problem hiding this comment.
Won't we need to reverse this in on_cancel?
There was a problem hiding this comment.
@fproldan I added the hook and some tests for this since it was a bit of a refactor. Can you review again?
|
@fproldan I forgot to add a test and logic for a cancelled manual Payment Entry. I'll let you know when this need another review. |
|
@fproldan Can you give this one another look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment Entries are (somehow) not responsible for updating the outstanding amount field(s) of their source documents. This should be fixed with this workflow. Frappe has a functionality to selectively update terms where a payment term exists, but it doesn't work with the manual API (
get_payment_entry("Purchase Invoice", pi_name))