Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEPA Payment Feature #234

Closed
wants to merge 27 commits into from
Closed

Conversation

viralkansodiya
Copy link
Contributor

@agritheory
Copy link
Owner

agritheory commented Apr 29, 2024

Please rebase this so that the new fields in Check Run settings are not dropped. This should target the version-15 branch.

When I start a new Check Run with "EUR Account Payable" (which should be "EUR Accounts Payable") I get the following error:

App Versions

{
	"check_run": "14.11.5",
	"erpnext": "14.58.1",
	"frappe": "14.62.1",
	"hrms": "14.24.1"
}

Route

Form/Check Run/ACC-CR-2024-00001

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 95, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 55, in handle
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 47, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1628, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/__init__.py", line 808, in wrapper_fn
    retval = fn(*args, **get_newargs(fn, kwargs))
  File "apps/check_run/check_run/check_run/doctype/check_run/check_run.py", line 592, in get_entries
    f"{settings.purchase_invoice}" or "\n",
AttributeError: 'NoneType' object has no attribute 'purchase_invoice'

Request Data

{
	"type": "POST",
	"args": {
		"doc": "{\"name\":\"ACC-CR-2024-00001\",\"owner\":\"Administrator\",\"creation\":\"2024-04-29 07:25:20.631500\",\"modified\":\"2024-04-29 07:25:20.631500\",\"modified_by\":\"Administrator\",\"docstatus\":0,\"idx\":0,\"end_date\":\"2024-04-29\",\"posting_date\":\"2024-04-29\",\"beg_balance\":49000,\"initial_check_number\":2501,\"final_check_number\":0,\"amount_check_run\":0,\"company\":\"Chelsea Fruit Co\",\"bank_account\":\"Primary Checking - Local Bank\",\"pay_to_account\":\"2110 - Accounts Payable - CFC\",\"print_count\":0,\"status\":\"Draft\",\"doctype\":\"Check Run\",\"__onload\":{\"settings\":{\"ach_description\":null,\"ach_file_extension\":\"ach\",\"ach_service_class_code\":\"200\",\"ach_standard_class_code\":\"PPD\",\"allow_cancellation\":0,\"automatically_release_on_hold_invoices\":0,\"bank_account\":\"Primary Checking - Local Bank\",\"cascade_cancellation\":0,\"company\":\"Chelsea Fruit Co\",\"company_discretionary_data\":null,\"creation\":\"2024-04-29 07:25:20.750969\",\"custom_post_processing_hook\":null,\"docstatus\":0,\"doctype\":\"Check Run Settings\",\"expense_claim\":null,\"file_preview_threshold\":1000,\"idx\":0,\"immediate_origin\":null,\"include_expense_claims\":1,\"include_journal_entries\":1,\"include_purchase_invoices\":1,\"journal_entry\":null,\"modified\":\"2024-04-29 07:25:20.750969\",\"modified_by\":\"Administrator\",\"name\":\"ACC-CRS-Primary Checking - Local Bank-2110 - Accounts Payable - CFC\",\"number_of_invoices_per_voucher\":0,\"owner\":\"Administrator\",\"pay_to_account\":\"2110 - Accounts Payable - CFC\",\"pre_check_overdue_items\":0,\"print_format\":null,\"purchase_invoice\":null,\"split_by_address\":0,\"validate_unique_check_number\":0},\"check_run_submitting\":false,\"pay_to_account_currency\":\"USD\"},\"__last_sync_on\":\"2024-04-29T11:32:09.962Z\",\"__unsaved\":1,\"__needs_refresh\":true}"
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/check_run.check_run.doctype.check_run.check_run.get_entries"
}

Response Data

{
	"exception": "AttributeError: 'NoneType' object has no attribute 'purchase_invoice'"
}

@agritheory agritheory marked this pull request as draft April 29, 2024 11:45
@viralkansodiya
Copy link
Contributor Author

@agritheory #236 for the same issue I faced, I have attached a video

@agritheory
Copy link
Owner

Closing in favor of #239

@agritheory agritheory closed this Apr 30, 2024
@viralkansodiya viralkansodiya deleted the sapa branch May 1, 2024 04:20
@viralkansodiya viralkansodiya restored the sapa branch May 1, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants