Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shortcut keys for power users #233

Draft
wants to merge 5 commits into
base: version-14
Choose a base branch
from

Conversation

bhattdevarsh
Copy link
Collaborator

@bhattdevarsh bhattdevarsh commented Apr 23, 2024

#190

  • Press ↑ arrow to move up in the row.
  • Press ↓ arrow to move down in the row.
  • Press Enter to enter the focused row's mode of payment.
  • Press Esc to come out of mode of payment.
  • Press Tab to regain the focus on rows.
key_shortcuts.mp4

@bhattdevarsh bhattdevarsh marked this pull request as draft April 24, 2024 09:22
Copy link
Owner

@agritheory agritheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install pre-commit and run prettier.

I am not seeing the keyboard shortcuts take effect in my test instance after running bench build.

This feature should be defeatable based on the number of invoice shown on the screen (use the same variable as preview in Check Run settings).

@agritheory agritheory self-requested a review May 16, 2024 12:54
@agritheory agritheory marked this pull request as ready for review May 16, 2024 12:54
@Alchez
Copy link
Collaborator

Alchez commented Jun 13, 2024

@bhattdevarsh I don't see any event listeners for the enter, tab and escape characters. And I get the following error while trying to press space on the 'Pay' button:

TypeError: Cannot read properties of undefined (reading '3')
    at updateSelectedRow (check_run.js:5838:29)
    at fn._withMods.fn._withMods (check_run.js:5512:14)
    at fn._withKeys.fn._withKeys (check_run.js:5531:16)
    at check_run.js:5302:62
    at callWithErrorHandling (check_run.js:1157:20)
    at callWithAsyncErrorHandling (check_run.js:1165:19)
    at callWithAsyncErrorHandling (check_run.js:1175:19)
    at HTMLTableRowElement.invoker (check_run.js:5284:7)

which is failing at the following line:

event.target.cells[3].firstChild.focus();

@agritheory agritheory marked this pull request as draft July 10, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants