Tax Payable #223
Tax Payable #223
Conversation
|
@basawaraj-fosserp Would love to discuss this at our next meeting |
|
Not sure how to defeat this notification, otherwise this seems to be ready to go.
|
check_run/tests/setup.py
Outdated
| for tax in taxes: | ||
| si.append("taxes", tax) | ||
| si.save() | ||
| si.submit() |
There was a problem hiding this comment.
Add at least one Credit Note to reflect returned items and a Journal Entry to reflect a write off.
|
@basawaraj-fosserp Adjacent, potentially overlapping use case: commissions payable. Potentially appropriate for Sales Partner (Supplier) or Sales Person (Employee or Supplier) as party types. Also potentially freight payable. |
|
There's one TODO left as of 6/4/24, which is to pull in the supplier default payment terms and payment due date. Normally this would have a a "days after month end" style of payment, we can use 25 days for testing purposes. |
outstanding amount is not updated some other warnings need to be defeated
* ci: remove cypress, fix hrms install, conform * ci: fix mypy error
* gl entry not created * replace super class validate
…up.before_test' (#231) * changes to added one credit note in setup.py * remove outstanding > 0 condition to take return entry in sales invoice * chech run creditnote test * compatible chnages to v15
outstanding amount is not updated some other warnings need to be defeated
agritheory
requested review from
viralkansodiya and
fproldan
and removed request for
viralkansodiya
check_run/overrides/sales_invoice.py
Outdated
|
|
||
|
|
||
| class CheckRunSalesInvoice(SalesInvoice): | ||
| # TODO: update due date in taxes with validate hook |
There was a problem hiding this comment.
Here is a TODO that I do not know if you want to do now
There was a problem hiding this comment.
@fproldan I think this can be removed, but I will add a test to ensure it's working.
| def on_submit(self): | ||
| for row in self.taxes: | ||
| if row.party and row.party_type: | ||
| row.outstanding_amount = row.tax_amount |
There was a problem hiding this comment.
I don't understand why here the outstanding_amount (and only this) is getting set again on_submit
There was a problem hiding this comment.
@fproldan @agritheory
I have removed the code mentioned by @fproldan and did some testing. Without this code, the calculation of the outstanding amount is also working perfectly.
We can remove this on_submit function from the overridden file.
|
Todos as of 6/18/24:
|
#218
Sales Taxes and Charges, before being paid via Check Run (Outstanding Amount is $8.12)
Example Check Run
Example config (Sales Invoices and JEs allowed, other doctypes shouldn't be)
Example Payment Entry / output of Check Run
Satisfied Sales Tax Payable (Outstanding Amount is $0.00)
