File Preview #140
Merged
File Preview #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fproldan Firefox is still misbehaving, Chrome works as expected. A third CRTL-SHIFT-R seems to solve it. |
fproldan
added a commit
that referenced
this pull request
Sep 8, 2023
* wip: file preview * feat: preview in check run, allow to preview in non submittable documents * feat: WIP payables attachment report * feat: wip preview of attachments * style: prettify code * feat: close with space * fix: do not open sidebar in check run * wip: multiple attachments in check run * fix: merge * style: prettify code * fix: df-preview-wrapper-fw * feat: improve code * feat: improve code * feat: columns --------- Co-authored-by: Tyler Matteson <[email protected]> Co-authored-by: fproldan <[email protected]>
agritheory
added a commit
that referenced
this pull request
Sep 11, 2023
* File Preview (#140) * wip: file preview * feat: preview in check run, allow to preview in non submittable documents * feat: WIP payables attachment report * feat: wip preview of attachments * style: prettify code * feat: close with space * fix: do not open sidebar in check run * wip: multiple attachments in check run * fix: merge * style: prettify code * fix: df-preview-wrapper-fw * feat: improve code * feat: improve code * feat: columns --------- Co-authored-by: Tyler Matteson <[email protected]> Co-authored-by: fproldan <[email protected]> * feat: use query builder in payables attachments report' * fix: build * fix: add remove btn * style: prettify code --------- Co-authored-by: Tyler Matteson <[email protected]> Co-authored-by: fproldan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#136