yourgov mutable steps #1929
yourgov mutable steps #1929
Conversation
🦋 Changeset detectedLatest commit: 52e7a21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ChrisLaneAU
changed the base branch from
develop
to
yourgov-review-and-submit-sub-level
ChrisLaneAU
changed the base branch from
yourgov-review-and-submit-sub-level
to
develop
ChrisLaneAU
force-pushed
the
yourgov-mutable-steps
branch
from
9117256 to
e4591a3
Compare
yourgov/components/FormMobileFoodVendorPermit/steps/stepsData.ts
Outdated
Show resolved
Hide resolved
|
| { | ||
| formStateKey: 'stepReviewAndSubmit', | ||
| label: 'Review and submit', | ||
| labelWhenChanging: 'Change review and submit', // Not used but it simplifies the type and makes the submit pages more robust |
There was a problem hiding this comment.
Haha. I wonder if we should just have a "Change" link component on the review page that simply does Change ${label.toLowerCase()}?
There was a problem hiding this comment.
lol we could but we have "Upload documents" that we don't want as "Change upload documents". What we really want is to separate the data collection steps form the review and submit step. Then the review and submit step doesn't need this value and validation could be mapped over the "data collection" steps. We could concatenate them for the purposes of the ProgressIndicator.
There was a problem hiding this comment.
Ah, "Change upload documents" what a pain in the butt!
Changes to the steps data so that they're not tightly coupled with their order allowing for reordering, adding, removing in one place.
View preview
Checklist
Preflight
accordion: Updated paddingordocs: Updated header linksyarn changeset. Learn more about change management.Testing
yarn testto ensure tests are passing. If required, runyarn test -uto update any generated snapshots.Documentation
Creating new component
docs/overview.mdxanddocs/code.mdxat a minimum)yarnin the root of the repo to do this)docs/components/designSystemComponents.tsx).storybook/stories/KitchenSink.tsx)docs/playroom/snippets.ts)figmaGalleryNodeIdto Docs (docs/components/pictograms/index.tsx)docs/components/pictograms/index.tsx)